Skip to content

fix(livekit): disable audio attachments by default - #656

Merged
Abhijeet Prasad (AbhiPrasad) merged 1 commit into
mainfrom
abhi-fix-disable-livekit-audio-attachments
Aug 5, 2026
Merged

fix(livekit): disable audio attachments by default#656
Abhijeet Prasad (AbhiPrasad) merged 1 commit into
mainfrom
abhi-fix-disable-livekit-audio-attachments

Conversation

@AbhiPrasad

Copy link
Copy Markdown
Member

Summary

  • disable LiveKit agent playback audio attachments by default
  • allow users to opt in with BRAINTRUST_CAPTURE_AGENT_AUDIO_ATTACHMENTS=true
  • preserve agent_speaking spans and synchronized transcripts when attachments are disabled
  • update the LiveKit setup documentation and regression coverage

This PR is stacked on #543, which introduces the generic audio attachment environment controls.

Validation

  • nox -s "test_livekit_agents(latest)" -- -k "agent_audio_capture_respects_generic_env or agent_speaking_e2e"
  • nox -s "test_livekit_agents(1.3.1)" -- -k "agent_audio_capture_respects_generic_env"
  • pre-commit checks on the changed files
  • pylint on the changed files

@lforst

Copy link
Copy Markdown
Member

hm hm hm, I thought we agreed to always capture automatically. Why suddenly not?

Base automatically changed from abhi-pipecat-integration to main August 5, 2026 14:09
Stop collecting and attaching agent playback audio unless
BRAINTRUST_CAPTURE_AGENT_AUDIO_ATTACHMENTS is explicitly enabled. Preserve
agent_speaking spans and transcripts when attachments are disabled.
@AbhiPrasad
Abhijeet Prasad (AbhiPrasad) force-pushed the abhi-fix-disable-livekit-audio-attachments branch from 33c2ebf to 0d04987 Compare August 5, 2026 14:09
@AbhiPrasad

Copy link
Copy Markdown
Member Author

hm hm hm, I thought we agreed to always capture automatically. Why suddenly not?

I went with this default for the first voice integration I built (livekit agents) and basically everyone who I spoke to who were building voice agents wanted this to be opt-in.

@lforst

Copy link
Copy Markdown
Member

good to know!

@AbhiPrasad
Abhijeet Prasad (AbhiPrasad) merged commit 62b3ca5 into main Aug 5, 2026
82 checks passed
@AbhiPrasad
Abhijeet Prasad (AbhiPrasad) deleted the abhi-fix-disable-livekit-audio-attachments branch August 5, 2026 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants